upkeep: add TS support for useTaxonomy hook
#303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
commented
Mar 3, 2024
package.json
Outdated
| @@ -55,6 +55,7 @@ | |||
| "@emotion/styled": "^11.10.5", | |||
| "@floating-ui/react-dom": "^1.0.1", | |||
| "@leeoniya/ufuzzy": "^1.0.8", | |||
| "@wordpress/core-data": "^6.29.0", | |||
There was a problem hiding this comment.
@fabiankaegy I've installed this so that I can import the Taxonomy type. Can you confirm if this is the correct way to go?
There was a problem hiding this comment.
@Sidsector9 I would move it to a devDependency because the package won't actually get bundled. But yeah this makes sense to me :)
1 failed test on run #805 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Repeater > Adding Repeater field and saving it. |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #303 ↗︎
Sidsector9
changed the title
useTaxonomy hookuseTaxonomy hook
|
Size Change: 0 B Total Size: 65.7 kB ℹ️ View Unchanged
|
|
@Sidsector9 I'm really surprised by the amount of changes in the package lock file. Are you by chance using a different NPM version? |
|
@fabiankaegy I'm on NPM v8.19.4. |
Sidsector9
force-pushed
the
upkeep/hook-use-taxonomy
branch
from
2c1020e
to
8997d66
Compare
…onents into upkeep/hook-use-taxonomy
fabiankaegy
requested changes
Mar 19, 2024
fabiankaegy
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
How to test the Change
Changelog Entry
Credits
Props @fabiankaegy @Sidsector9
Checklist: